You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix keyed reconcile in @solidjs/signals so array entries that are null, undefined, or primitives are treated as direct values instead of being wrapped as store objects.
Preserve keyed object reconciliation for wrappable entries while replacing non-object entries safely.
Add regression coverage for nullable keyed arrays and object-to-primitive array replacement.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks for catching this and for the PR, @cyphercodes! 🙏
We've landed a fix for #2772 in bc92d002 on next. It takes a slightly broader approach than this PR: rather than guarding a single site, it guards every keyed-diff touch point (match / key / wrap) in both the fast and slow applyState paths, so null/undefined/primitive entries are safely preserved or replaced wholesale in any position (leading/trailing scans and the map/LIS reorder), including object→primitive and back.
We also added a UIBench-tree store-reconcile Tier-1 bench (reconcile-tree.bench.ts) and confirmed the guards add no measurable cost to the keyed reorder path.
Closing since the issue is now fixed on next, but thank you again — the report and repro were spot on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconcilein@solidjs/signalsso array entries that arenull,undefined, or primitives are treated as direct values instead of being wrapped as store objects.Closes #2772
How did you test this change?
pnpm --dir packages/solid-signals exec vitest run tests/store/reconcile.test.tspnpm --filter @solidjs/signals testpnpm --filter @solidjs/signals buildpnpm exec prettier --check packages/solid-signals/src/store/reconcile.ts packages/solid-signals/tests/store/reconcile.test.tsgit diff --checkpnpm test